1. 17 Jan, 2020 1 commit
    • Alerting: Fix image rendering and uploading timeout preventing to send alert notifications (#21536) · 71ffd1d1
      * svc alerting - use a shorter ctx to upload the img
      This will prevent timeout on img upload to cancel the notifications from being sent
      
      * components img uploader - pass the ctx to aws lib
      
      * make webdavuploader use the ctx
      
      * make azureblobuploader use the ctx
      
      * rename uploadImage() to renderAndUploadImage()
      for better clarity about what this method work
      
      * Use timeout + 2s for plugin renderer (same as service and phantomjs)
      
      * Make sure that original EvalContext is updated after render and upload
      
      * Verify notification sent even if render or image upload times out
      
      * fix lint
      
      * fixes after review
      
      Co-authored-by: Edouard Hur <3418467+hekmon@users.noreply.github.com>
      
      Fixes #21018
      Marcus Efraimsson committed
  2. 02 Jan, 2020 1 commit
  3. 23 Oct, 2019 1 commit
  4. 10 Oct, 2019 1 commit
  5. 04 Jun, 2019 1 commit
  6. 22 May, 2019 1 commit
  7. 13 May, 2019 1 commit
  8. 08 May, 2019 1 commit
  9. 23 Apr, 2019 1 commit
    • Chore: a bit of spring cleaning (#16710) · 54c1bf0c
      * Chore: use early return technic everywhere
      
      And enable "indent-error-flow" revive rule
      
      * Chore: remove if-return rule from revive config
      
      * Chore: improve error messages
      
      And enable "error-strings" revive rule
      
      * Chore: enable "error-naming" revive rule
      
      * Chore: make linter happy
      
      * Chore: do not duplicate gofmt execution
      
      * Chore: make linter happy
      
      * Chore: address the pull review comments
      Oleg Gaidarenko committed
  10. 28 Mar, 2019 1 commit
  11. 15 Jan, 2019 1 commit
  12. 01 Oct, 2018 1 commit
    • Fix megacheck issue unused code. · dde65090
      I removed some code, and commented out other one.
      
      See,
      $ gometalinter --vendor --disable-all --disable=gotype --enable=megacheck --deadline 6m ./... | grep unused
      pkg/api/avatar/avatar.go:100:26:warning: func (*CacheServer).mustInt is unused (U1000) (megacheck)
      pkg/api/folder_test.go:136:6:warning: func callGetFolderByUID is unused (U1000) (megacheck)
      pkg/api/folder_test.go:141:6:warning: func callDeleteFolder is unused (U1000) (megacheck)
      pkg/api/live/hub.go:40:15:warning: func (*hub).removeConnection is unused (U1000) (megacheck)
      pkg/components/imguploader/azureblobuploader.go:130:5:warning: var client is unused (U1000) (megacheck)
      pkg/middleware/middleware_test.go:438:28:warning: func (*scenarioContext).withInvalidApiKey is unused (U1000) (megacheck)
      pkg/services/alerting/ticker.go:40:18:warning: func (*Ticker).updateOffset is unused (U1000) (megacheck)
      pkg/services/notifications/notifications_test.go:12:6:warning: type testTriggeredAlert is unused (U1000) (megacheck)
      pkg/services/sqlstore/dashboard_service_integration_test.go:935:6:warning: type scenarioContext is unused (U1000) (megacheck)
      pkg/services/sqlstore/dashboard_service_integration_test.go:939:6:warning: type scenarioFunc is unused (U1000) (megacheck)
      pkg/services/sqlstore/dashboard_service_integration_test.go:941:6:warning: func dashboardGuardianScenario is unused (U1000) (megacheck)
      pkg/services/sqlstore/transactions_test.go:13:6:warning: type testQuery is unused (U1000) (megacheck)
      Mario Trangoni committed
  13. 26 Sep, 2018 1 commit
  14. 21 Sep, 2018 2 commits
    • Fix some typos found by codespell · 80fa66fc
      See,
      $ codespell -S "./.git*,./vendor*,./public*"
      Mario Trangoni committed
    • Fix misspell issues · 3689bb77
      See,
      $ gometalinter --disable-all --enable misspell --deadline 10m --vendor ./...
      pkg/api/dtos/alerting_test.go:32:13:warning: "expectes" is a misspelling of "expects" (misspell)
      pkg/api/static/static.go:2:18:warning: "Unknwon" is a misspelling of "Unknown" (misspell)
      pkg/components/imguploader/azureblobuploader.go:55:48:warning: "conatiner" is a misspelling of "container" (misspell)
      pkg/login/ldap_settings.go:51:115:warning: "compatability" is a misspelling of "compatibility" (misspell)
      pkg/middleware/auth_proxy_test.go:122:22:warning: "Destory" is a misspelling of "Destroy" (misspell)
      pkg/middleware/logger.go:2:18:warning: "Unknwon" is a misspelling of "Unknown" (misspell)
      pkg/services/notifications/codes.go:9:13:warning: "Unknwon" is a misspelling of "Unknown" (misspell)
      pkg/services/session/mysql.go:170:3:warning: "Destory" is a misspelling of "Destroy" (misspell)
      pkg/services/session/mysql.go:171:24:warning: "Destory" is a misspelling of "Destroy" (misspell)
      pkg/services/session/session.go:95:4:warning: "Destory" is a misspelling of "Destroy" (misspell)
      pkg/services/session/session.go:96:1:warning: "Destory" is a misspelling of "Destroy" (misspell)
      pkg/services/session/session.go:167:25:warning: "Destory" is a misspelling of "Destroy" (misspell)
      pkg/setting/setting.go:1:18:warning: "Unknwon" is a misspelling of "Unknown" (misspell)
      pkg/tsdb/cloudwatch/cloudwatch.go:199:14:warning: "resolutin" is a misspelling of "resolutions" (misspell)
      pkg/tsdb/cloudwatch/cloudwatch.go:270:15:warning: "resolutin" is a misspelling of "resolutions" (misspell)
      pkg/tsdb/elasticsearch/response_parser.go:531:24:warning: "Unkown" is a misspelling of "Unknown" (misspell)
      pkg/tsdb/elasticsearch/client/search_request.go:113:7:warning: "initaite" is a misspelling of "initiate" (misspell)
      
      Note: Unknwon is a library name, and Destory a mysql typo.
      Mario Trangoni committed
  15. 28 Aug, 2018 1 commit
  16. 17 Jul, 2018 1 commit
  17. 30 Apr, 2018 1 commit
  18. 23 Apr, 2018 1 commit
  19. 16 Apr, 2018 1 commit
  20. 12 Jan, 2018 1 commit
  21. 28 Dec, 2017 1 commit
  22. 27 Dec, 2017 1 commit
  23. 21 Nov, 2017 1 commit
  24. 04 Oct, 2017 1 commit
  25. 28 Sep, 2017 1 commit
  26. 19 Sep, 2017 1 commit
  27. 15 Sep, 2017 7 commits
  28. 13 Sep, 2017 1 commit
  29. 23 May, 2017 1 commit
  30. 17 May, 2017 1 commit
  31. 16 May, 2017 1 commit
  32. 01 May, 2017 1 commit
  33. 25 Apr, 2017 1 commit