- 17 Jan, 2020 1 commit
-
-
* svc alerting - use a shorter ctx to upload the img This will prevent timeout on img upload to cancel the notifications from being sent * components img uploader - pass the ctx to aws lib * make webdavuploader use the ctx * make azureblobuploader use the ctx * rename uploadImage() to renderAndUploadImage() for better clarity about what this method work * Use timeout + 2s for plugin renderer (same as service and phantomjs) * Make sure that original EvalContext is updated after render and upload * Verify notification sent even if render or image upload times out * fix lint * fixes after review Co-authored-by: Edouard Hur <3418467+hekmon@users.noreply.github.com> Fixes #21018
Marcus Efraimsson committed
-
- 02 Jan, 2020 1 commit
-
-
* imguploader: add support for non-Amazon S3 endpoints and forcing of path-style S3 addressing fixes #11240 Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
Paul Emmerich committed
-
- 23 Oct, 2019 1 commit
-
-
* pkg/util: Check errors * pkg/services: DRY up code
Arve Knudsen committed
-
- 10 Oct, 2019 1 commit
-
-
* pkg/components: Check errors
Arve Knudsen committed
-
- 04 Jun, 2019 1 commit
-
-
ref #10381 Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
Mario Trangoni committed
-
- 22 May, 2019 1 commit
-
-
Signed-off-by: CodeLingo Bot <bot@codelingo.io>
CodeLingo Bot committed
-
- 13 May, 2019 1 commit
-
-
ref #14679 Signed-off-by: zhulongcheng <zhulongcheng.me@gmail.com>
zhulongcheng committed
-
- 08 May, 2019 1 commit
-
-
Deprecated: Fast Fallback is enabled by default. To disable, set FallbackDelay to a negative value. https://golang.org/src/net/dial.go
Carl Bergquist committed
-
- 23 Apr, 2019 1 commit
-
-
* Chore: use early return technic everywhere And enable "indent-error-flow" revive rule * Chore: remove if-return rule from revive config * Chore: improve error messages And enable "error-strings" revive rule * Chore: enable "error-naming" revive rule * Chore: make linter happy * Chore: do not duplicate gofmt execution * Chore: make linter happy * Chore: address the pull review comments
Oleg Gaidarenko committed
-
- 28 Mar, 2019 1 commit
-
-
See https://github.com/securego/gosec for more info. Disabled a lot of rules. I guess we should go through them and recheck if we really need to disable some Fixes #16204
Oleg Gaidarenko committed
-
- 15 Jan, 2019 1 commit
-
-
bergquist committed
-
- 01 Oct, 2018 1 commit
-
-
I removed some code, and commented out other one. See, $ gometalinter --vendor --disable-all --disable=gotype --enable=megacheck --deadline 6m ./... | grep unused pkg/api/avatar/avatar.go:100:26:warning: func (*CacheServer).mustInt is unused (U1000) (megacheck) pkg/api/folder_test.go:136:6:warning: func callGetFolderByUID is unused (U1000) (megacheck) pkg/api/folder_test.go:141:6:warning: func callDeleteFolder is unused (U1000) (megacheck) pkg/api/live/hub.go:40:15:warning: func (*hub).removeConnection is unused (U1000) (megacheck) pkg/components/imguploader/azureblobuploader.go:130:5:warning: var client is unused (U1000) (megacheck) pkg/middleware/middleware_test.go:438:28:warning: func (*scenarioContext).withInvalidApiKey is unused (U1000) (megacheck) pkg/services/alerting/ticker.go:40:18:warning: func (*Ticker).updateOffset is unused (U1000) (megacheck) pkg/services/notifications/notifications_test.go:12:6:warning: type testTriggeredAlert is unused (U1000) (megacheck) pkg/services/sqlstore/dashboard_service_integration_test.go:935:6:warning: type scenarioContext is unused (U1000) (megacheck) pkg/services/sqlstore/dashboard_service_integration_test.go:939:6:warning: type scenarioFunc is unused (U1000) (megacheck) pkg/services/sqlstore/dashboard_service_integration_test.go:941:6:warning: func dashboardGuardianScenario is unused (U1000) (megacheck) pkg/services/sqlstore/transactions_test.go:13:6:warning: type testQuery is unused (U1000) (megacheck)
Mario Trangoni committed
-
- 26 Sep, 2018 1 commit
-
-
Aidan Rowe committed
-
- 21 Sep, 2018 2 commits
-
-
See, $ codespell -S "./.git*,./vendor*,./public*"
Mario Trangoni committed -
See, $ gometalinter --disable-all --enable misspell --deadline 10m --vendor ./... pkg/api/dtos/alerting_test.go:32:13:warning: "expectes" is a misspelling of "expects" (misspell) pkg/api/static/static.go:2:18:warning: "Unknwon" is a misspelling of "Unknown" (misspell) pkg/components/imguploader/azureblobuploader.go:55:48:warning: "conatiner" is a misspelling of "container" (misspell) pkg/login/ldap_settings.go:51:115:warning: "compatability" is a misspelling of "compatibility" (misspell) pkg/middleware/auth_proxy_test.go:122:22:warning: "Destory" is a misspelling of "Destroy" (misspell) pkg/middleware/logger.go:2:18:warning: "Unknwon" is a misspelling of "Unknown" (misspell) pkg/services/notifications/codes.go:9:13:warning: "Unknwon" is a misspelling of "Unknown" (misspell) pkg/services/session/mysql.go:170:3:warning: "Destory" is a misspelling of "Destroy" (misspell) pkg/services/session/mysql.go:171:24:warning: "Destory" is a misspelling of "Destroy" (misspell) pkg/services/session/session.go:95:4:warning: "Destory" is a misspelling of "Destroy" (misspell) pkg/services/session/session.go:96:1:warning: "Destory" is a misspelling of "Destroy" (misspell) pkg/services/session/session.go:167:25:warning: "Destory" is a misspelling of "Destroy" (misspell) pkg/setting/setting.go:1:18:warning: "Unknwon" is a misspelling of "Unknown" (misspell) pkg/tsdb/cloudwatch/cloudwatch.go:199:14:warning: "resolutin" is a misspelling of "resolutions" (misspell) pkg/tsdb/cloudwatch/cloudwatch.go:270:15:warning: "resolutin" is a misspelling of "resolutions" (misspell) pkg/tsdb/elasticsearch/response_parser.go:531:24:warning: "Unkown" is a misspelling of "Unknown" (misspell) pkg/tsdb/elasticsearch/client/search_request.go:113:7:warning: "initaite" is a misspelling of "initiate" (misspell) Note: Unknwon is a library name, and Destory a mysql typo.
Mario Trangoni committed
-
- 28 Aug, 2018 1 commit
-
-
bergquist committed
-
- 17 Jul, 2018 1 commit
-
-
Jakob van Santen committed
-
- 30 Apr, 2018 1 commit
-
-
* wip: start on refactoring settings * settings: progress on settings refactor * refactor: progress on settings refactoring * fix: fixed failing test * settings: moved smtp settings from global to instance
Torkel Ödegaard committed
-
- 23 Apr, 2018 1 commit
-
-
Mario Trangoni committed
-
- 16 Apr, 2018 1 commit
-
-
Mario Trangoni committed
-
- 12 Jan, 2018 1 commit
-
-
Martin Szulecki committed
-
- 28 Dec, 2017 1 commit
-
-
bergquist committed
-
- 27 Dec, 2017 1 commit
-
-
Mahmoud Saada committed
-
- 21 Nov, 2017 1 commit
-
-
saady committed
-
- 04 Oct, 2017 1 commit
-
-
Ricard Clau committed
-
- 28 Sep, 2017 1 commit
-
-
Default transport enables it: * https://github.com/golang/go/blob/d2826d3e06/src/net/http/transport.go#L42-L46 ``` DialContext: (&net.Dialer{ Timeout: 30 * time.Second, KeepAlive: 30 * time.Second, DualStack: true, }).DialContext, ``` See also: https://github.com/golang/go/issues/15324
Ivan Babrou committed
-
- 19 Sep, 2017 1 commit
-
-
this is to support cn-north-1 region as it can get s3 url programatically. also keeps support 'bucket_url' for backward compatiblity
William committed
-
- 15 Sep, 2017 7 commits
-
-
bergquist committed
-
bergquist committed
-
bergquist committed
-
Konstantin Chukhlomin committed
-
Konstantin Chukhlomin committed
-
Konstantin Chukhlomin committed
-
Konstantin Chukhlomin committed
-
- 13 Sep, 2017 1 commit
-
-
William committed
-
- 23 May, 2017 1 commit
-
-
fix: s3 image uploads to us-east-1 (us standard) did not return correct image urls so images shared to slack and other services was not correct, fixes #8444
Torkel Ödegaard committed
-
- 17 May, 2017 1 commit
-
-
berghauz committed
-
- 16 May, 2017 1 commit
-
-
Well, i'm really want to see it working in 4.3.0
berghauz committed
-
- 01 May, 2017 1 commit
-
-
rogerswingle committed
-
- 25 Apr, 2017 1 commit
-
-
Fixes #7914. Fixes #7921
Daniel Lee committed
-