1. 25 Jan, 2019 3 commits
    • scripts/build/*: Fix some golint issues · 4b68055c
      See,
      
      $ gometalinter --vendor --disable-all --enable=golint ./...
      build/release_publisher/externalrelease.go:55:6:warning: type getHttpContents should be getHTTPContents (golint)
      build/release_publisher/publisher.go:18:2:warning: struct field apiUri should be apiURI (golint)
      build/release_publisher/publisher.go:66:6:warning: exported type ReleaseType should have comment or be unexported (golint)
      build/release_publisher/publisher.go:69:2:warning: exported const STABLE should have comment (or a comment on this block) or be unexported (golint)
      build/release_publisher/publisher.go:185:16:warning: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
      build/release_publisher/publisher_test.go:102:6:warning: type mockHttpGetter should be mockHTTPGetter (golint)
      Mario Trangoni committed
    • scripts/build/*: Fix golint issues Url => URL · d5f63d99
      $ gometalinter --vendor --disable-all --enable=golint ./... | grep -i URL
      build/publish.go:18:5:warning: var apiUrl should be apiURL (golint)
      build/publish.go:184:2:warning: struct field WhatsNewUrl should be WhatsNewURL (golint)
      build/publish.go:185:2:warning: struct field ReleaseNotesUrl should be ReleaseNotesURL (golint)
      build/publish.go:191:2:warning: struct field Url should be URL (golint)
      build/release_publisher/externalrelease.go:17:53:warning: method parameter baseArchiveUrl should be baseArchiveURL (golint)
      build/release_publisher/externalrelease.go:17:69:warning: method parameter whatsNewUrl should be whatsNewURL (golint)
      build/release_publisher/externalrelease.go:17:89:warning: method parameter releaseNotesUrl should be releaseNotesURL (golint)
      build/release_publisher/localrelease.go:20:45:warning: method parameter baseArchiveUrl should be baseArchiveURL (golint)
      build/release_publisher/localrelease.go:20:61:warning: method parameter whatsNewUrl should be whatsNewURL (golint)
      build/release_publisher/localrelease.go:20:81:warning: method parameter releaseNotesUrl should be releaseNotesURL (golint)
      build/release_publisher/localrelease.go:45:41:warning: method parameter baseArchiveUrl should be baseArchiveURL (golint)
      build/release_publisher/localrelease.go:51:84:warning: func parameter baseArchiveUrl should be baseArchiveURL (golint)
      build/release_publisher/main.go:12:6:warning: var whatsNewUrl should be whatsNewURL (golint)
      build/release_publisher/main.go:13:6:warning: var releaseNotesUrl should be releaseNotesURL (golint)
      build/release_publisher/main.go:40:6:warning: var baseUrl should be baseURL (golint)
      build/release_publisher/main.go:94:6:warning: func createBaseUrl should be createBaseURL (golint)
      build/release_publisher/publisher.go:21:2:warning: struct field baseArchiveUrl should be baseArchiveURL (golint)
      build/release_publisher/publisher.go:26:17:warning: interface method parameter baseArchiveUrl should be baseArchiveURL (golint)
      build/release_publisher/publisher.go:26:33:warning: interface method parameter whatsNewUrl should be whatsNewURL (golint)
      build/release_publisher/publisher.go:26:53:warning: interface method parameter releaseNotesUrl should be releaseNotesURL (golint)
      build/release_publisher/publisher.go:29:31:warning: method parameter whatsNewUrl should be whatsNewURL (golint)
      build/release_publisher/publisher.go:29:51:warning: method parameter releaseNotesUrl should be releaseNotesURL (golint)
      build/release_publisher/publisher.go:91:24:warning: method getUrl should be getURL (golint)
      build/release_publisher/publisher.go:91:31:warning: method parameter baseArchiveUrl should be baseArchiveURL (golint)
      build/release_publisher/publisher.go:190:15:warning: func parameter baseArchiveUrl should be baseArchiveURL (golint)
      build/release_publisher/publisher.go:199:21:warning: method apiUrl should be apiURL (golint)
      build/release_publisher/publisher.go:257:2:warning: struct field WhatsNewUrl should be WhatsNewURL (golint)
      build/release_publisher/publisher.go:258:2:warning: struct field ReleaseNotesUrl should be ReleaseNotesURL (golint)
      build/release_publisher/publisher.go:264:2:warning: struct field Url should be URL (golint)
      build/release_publisher/publisher_test.go:10:3:warning: struct field whatsNewUrl should be whatsNewURL (golint)
      build/release_publisher/publisher_test.go:11:3:warning: struct field relNotesUrl should be relNotesURL (golint)
      build/release_publisher/publisher_test.go:17:3:warning: struct field expectedUrl should be expectedURL (golint)
      build/release_publisher/publisher_test.go:18:3:warning: struct field baseArchiveUrl should be baseArchiveURL (golint)
      build/release_publisher/publisher_test.go:109:2:warning: var whatsNewUrl should be whatsNewURL (golint)
      build/release_publisher/publisher_test.go:110:2:warning: var relNotesUrl should be relNotesURL (golint)
      Mario Trangoni committed
  2. 23 Jan, 2019 25 commits
  3. 22 Jan, 2019 12 commits